-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrency issue on connection tracker #575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvin681
requested review from
nickmahilani,
jeffchao,
piygoyal,
sundargates,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
November 2, 2023 18:01
calvin681
had a problem deploying
to
Integrate Pull Request
November 2, 2023 18:01 — with
GitHub Actions
Failure
Andyz26
approved these changes
Nov 2, 2023
calvin681
had a problem deploying
to
Integrate Pull Request
November 2, 2023 18:38 — with
GitHub Actions
Failure
calvin681
temporarily deployed
to
Integrate Pull Request
November 2, 2023 18:56 — with
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle.
|
calvin681
force-pushed
the
ccheung/ccheung_dev
branch
from
November 6, 2023 17:26
249b8a3
to
7001918
Compare
calvin681
temporarily deployed
to
Integrate Pull Request
November 6, 2023 17:26 — with
GitHub Actions
Inactive
calvin681
force-pushed
the
ccheung/ccheung_dev
branch
from
November 6, 2023 19:05
7001918
to
8ec0a49
Compare
calvin681
temporarily deployed
to
Integrate Pull Request
November 6, 2023 19:05 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There can be a race condition if
closeConn
is called too quickly, where the channel is created on the observable andcloseConn
is called at the same time. Also added logic to close the channel immediate if thecloseConn
was already called.Checklist
./gradlew build
compiles code correctly./gradlew test
passes all tests