Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issue on connection tracker #575

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

calvin681
Copy link
Collaborator

@calvin681 calvin681 commented Nov 2, 2023

Context

There can be a race condition if closeConn is called too quickly, where the channel is created on the observable and closeConn is called at the same time. Also added logic to close the channel immediate if the closeConn was already called.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

github-actions bot commented Nov 2, 2023

Test Results

545 tests  ±0   537 ✔️ ±0   7m 39s ⏱️ + 1m 12s
128 suites ±0       8 💤 ±0 
128 files   ±0       0 ±0 

Results for commit 8ec0a49. ± Comparison against base commit d09cb9a.

♻️ This comment has been updated with latest results.

@calvin681 calvin681 had a problem deploying to Integrate Pull Request November 2, 2023 18:38 — with GitHub Actions Failure
@calvin681 calvin681 temporarily deployed to Integrate Pull Request November 2, 2023 18:56 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 2, 2023

Uploaded Artifacts

To use these artifacts in your Gradle project, paste the following lines in your build.gradle.

resolutionStrategy {
    force "io.mantisrx:mantis-client:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-common:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-common-serde:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-discovery-proto:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-network:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-remote-observable:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-runtime:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-runtime-loader:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-shaded:0.1.0-20231106.212350-419"
    force "io.mantisrx:mantis-testcontainers:0.1.0-20231106.212350-90"
    force "io.mantisrx:mantis-connector-iceberg:0.1.0-20231106.212350-419"
    force "io.mantisrx:mantis-connector-job:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-connector-kafka:0.1.0-20231106.212350-421"
    force "io.mantisrx:mantis-connector-publish:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-control-plane-client:0.1.0-20231106.212350-420"
    force "io.mantisrx:mantis-control-plane-core:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-control-plane-server:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-core:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-groupby-sample:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-jobconnector-sample:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-mantis-publish-sample:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-sine-function:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-synthetic-sourcejob:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-twitter-sample:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-examples-wordcount:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-publish-core:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-publish-netty:0.1.0-20231106.212350-413"
    force "io.mantisrx:mantis-publish-netty-guice:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-server-agent:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-server-worker:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-server-worker-client:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-source-job-kafka:0.1.0-20231106.212350-414"
    force "io.mantisrx:mantis-source-job-publish:0.1.0-20231106.212350-414"
}

@calvin681 calvin681 force-pushed the ccheung/ccheung_dev branch from 249b8a3 to 7001918 Compare November 6, 2023 17:26
@calvin681 calvin681 temporarily deployed to Integrate Pull Request November 6, 2023 17:26 — with GitHub Actions Inactive
@calvin681 calvin681 force-pushed the ccheung/ccheung_dev branch from 7001918 to 8ec0a49 Compare November 6, 2023 19:05
@calvin681 calvin681 temporarily deployed to Integrate Pull Request November 6, 2023 19:05 — with GitHub Actions Inactive
@calvin681 calvin681 merged commit 8c9aaa7 into master Nov 6, 2023
@calvin681 calvin681 deleted the ccheung/ccheung_dev branch November 6, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants