Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates to Slack file upload v2 API call #5796

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Migrates to Slack file upload v2 API call #5796

merged 2 commits into from
Mar 4, 2025

Conversation

mvilanova
Copy link
Contributor

Changes

  • Updated the Slack file upload method from files_upload to files_upload_v2 in the SlackConversationPlugin class
  • Changed parameter name from channels to channel to match the new API requirements
  • Modified the channel value to use the conversation ID from signal_response.get("id") instead of using conversation_id
  • Added a comment explaining that we need the conversation ID, not the name
  • Removed the filetype="json" parameter as it's no longer needed in the v2 API

This change ensures compatibility with Slack's updated file upload API.

Screenshot 2025-03-03 at 2 27 54 PM

@mvilanova mvilanova added the enhancement New feature or request label Mar 3, 2025
@mvilanova mvilanova requested review from a team, aliciamatsumoto, milavent, whitdog47, wssheldon and security-hashira and removed request for a team March 3, 2025 22:35
@mvilanova mvilanova merged commit 6e14e48 into main Mar 4, 2025
9 checks passed
@mvilanova mvilanova deleted the feat/file-upload-v2 branch March 4, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitdog47 whitdog47 whitdog47 approved these changes

@aliciamatsumoto aliciamatsumoto Awaiting requested review from aliciamatsumoto aliciamatsumoto was automatically assigned from Netflix/dispatch-management

@milavent milavent Awaiting requested review from milavent milavent was automatically assigned from Netflix/dispatch-management

@wssheldon wssheldon Awaiting requested review from wssheldon

@security-hashira security-hashira Awaiting requested review from security-hashira

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvilanova @whitdog47 @aaronherman