update federation-jvm to 5.3.0 #2107
Merged
+731
−731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`federation-jvm` v5 included a bump to a protobuf v4 version which is not ABI compatible with protobuf v3. A lot of the libraries in the `grpc` ecosystem are still stuck at v3 (including `grpc-java`) and since `federation-jvm` only uses protobuf to generate messages, the latest `federation-jvm` version also downgrades its dependency back to a v3 version (which generates messages that are compatible with both v3 and v4 versions of protobuf). related: * apollographql/federation-jvm#421 * grpc/grpc-java#11015
dariuszkuc
requested review from
paulbakker,
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
federation-jvmv5 included a bump to a protobuf v4 version which is not ABI compatible with protobuf v3. Using protobuf v4 generates messages with a protobuf v3 service results in a runtime exception. A lot of the libraries in thegrpcecosystem are still stuck at v3 (includinggrpc-java) and sincefederation-jvmonly uses protobuf to generate messages, the latestfederation-jvmversion (5.3.0) also downgrades its dependency back to a v3 version (which generates messages that are compatible with both v3 and v4 versions of protobuf).see: