Dgs headers backward compatibility #2104
Merged
+155
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er a field in "extensions" or using DgsExecutionResult. While users can now just use WebGraphQlInterceptor, this adds compatibility with the old mechanism.
paulbakker
requested review from
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
dokkaraman
reviewed
Jan 8, 2025
...kotlin/com/netflix/graphql/dgs/springgraphql/autoconfig/DgsSpringGraphQLAutoConfiguration.kt
Outdated
Show resolved
Hide resolved
dokkaraman
reviewed
Jan 8, 2025
...phql/src/test/kotlin/com/netflix/graphql/dgs/springgraphql/autoconfig/DgsHeadersSmokeTest.kt
Show resolved
Hide resolved
srinivasankavitha
approved these changes
Jan 8, 2025
iuliiasobolevska
approved these changes
Jan 8, 2025
iparadiso
approved these changes
Jan 8, 2025
paulbakker
force-pushed
the
feature/dgs-headers-backward-compatibility
branch
from
77e769b to
06bb0d7
Compare
|
May I know in which version this would be available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2101. Prior to Spring GraphQL integration we could set response headers in two ways:
dgs-response-headersin theextensionsof anExecutionResult.DgsExecutionResultwhich has aheadersfield.This functionality stopped working, because
DgsExecutionResult(which was responsible for both mechanisms) was no longer referenced in the framework, so the special handling stopped working.While the now recommended mechanism is to implement a
WebGraphQlInterceptorto set headers as described in the docs, existing code would have to be updated.This PR adds support for the previous mechanisms. The implementation is now based on a
WebGraphQlInterceptor.