Undo switch to ScheduledDataLoaderRegistry and revert to DgsDataLoaderRegistry #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasankavitha
force-pushed
the
kavitha/revert-scheduled-dataloader-registry
branch
from
a0fe156 to
d9e3c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This PR reverts a recent change to use ScheduledDataLoaderRegistry introduced in
v8.0.0. We use the delegating wrapper DgsDataLoaderRegistry as was the case prior tov8.0.0due to this issue.The ScheduledDataLoaderRegistry creates a new ScheduledExecutorService (even if we use an injected executor) in the builder. This is done per request and ends up using way too much memory for high RPS services.
This change is temporary and will be reverted back to usethe SCheduledDataLoaderRegistry once we have the new release in graphql-java with a fix.