Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve IntelliJ support for json fields #1683

Merged
merged 4 commits into from
Nov 8, 2023
Merged

feat: Improve IntelliJ support for json fields #1683

merged 4 commits into from
Nov 8, 2023

Conversation

rahulsom
Copy link
Contributor

These usages in particular are useful when writing tests.

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

The two constructors in GraphQLResponse have the json field annotated as containing JSON.

Alternatives considered

N/A

@rahulsom
feat: Improve IntelliJ support for json fields
db1d9f5 
These usages in particular are useful when writing tests.
srinivasankavitha
srinivasankavitha approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@srinivasankavitha srinivasankavitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @rahulsom.

@rahulsom rahulsom marked this pull request as ready for review October 26, 2023 17:52
@rahulsom
Copy link
Contributor Author

rahulsom commented Nov 3, 2023

@srinivasankavitha Please let me know if other changes are needed.

@paulbakker paulbakker merged commit 5942457 into Netflix:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivasankavitha srinivasankavitha srinivasankavitha approved these changes

@paulbakker paulbakker paulbakker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulsom @paulbakker @srinivasankavitha