If a spring.autoconfigure.exclude property is defined in a test prope…

…rty source, don't undo the override in the ExcludeAutoConfigurationsEnvironmentPostProcessor
Netflix · Jan 7, 2025 · f0eb24b · f0eb24b
1 parent a300767
commit f0eb24b
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/...graphql/dgs/springgraphql/autoconfig/ExcludeAutoConfigurationsEnvironmentPostProcessor.kt b/...graphql/dgs/springgraphql/autoconfig/ExcludeAutoConfigurationsEnvironmentPostProcessor.kt
@@ -59,8 +59,15 @@ class ExcludeAutoConfigurationsEnvironmentPostProcessor : EnvironmentPostProcess
             )
     }
 
-    private fun extractAllExcludes(propertySources: MutablePropertySources): String =
-        propertySources
+    private fun extractAllExcludes(propertySources: MutablePropertySources): String {
+        if (propertySources.any { it.name == INLINED_TEST_PROPERTIES }) {
+            val testExclude = propertySources.find { it.name == INLINED_TEST_PROPERTIES }?.getProperty(EXCLUDE)
+            if (testExclude is String && testExclude.isNotBlank()) {
+                return testExclude
+            }
+        }
+
+        return propertySources
             .stream()
             .filter { src -> !ConfigurationPropertySources.isAttachedConfigurationPropertySource(src) }
             .map { src ->
@@ -71,6 +78,7 @@ class ExcludeAutoConfigurationsEnvironmentPostProcessor : EnvironmentPostProcess
                     }.orElse(emptyList())
             }.flatMap { it.stream() }
             .collect(Collectors.joining(","))
+    }
 
     companion object {
         private val DISABLE_AUTOCONFIG_PROPERTIES =
@@ -86,5 +94,6 @@ class ExcludeAutoConfigurationsEnvironmentPostProcessor : EnvironmentPostProcess
             )
 
         private const val EXCLUDE = "spring.autoconfigure.exclude"
+        private const val INLINED_TEST_PROPERTIES = "Inlined Test Properties"
     }
 }
diff --git a/...hql/dgs/springgraphql/autoconfig/ExcludeAutoConfigurationsEnvironmentPostProcessorTest.kt b/...hql/dgs/springgraphql/autoconfig/ExcludeAutoConfigurationsEnvironmentPostProcessorTest.kt
@@ -61,4 +61,22 @@ class ExcludeAutoConfigurationsEnvironmentPostProcessorTest {
                 "org.springframework.boot.autoconfigure.graphql.security.GraphQlWebMvcSecurityAutoConfiguration",
             )
     }
+
+    @Test
+    fun `does not reintroduce overridden excludes in test properties`() {
+        val env = StandardEnvironment()
+        env.propertySources.addLast(MapPropertySource("application-props", mapOf(Pair("spring.autoconfigure.exclude", "someexclude"))))
+        env.propertySources.addLast(MapPropertySource("Inlined Test Properties", mapOf(Pair("spring.autoconfigure.exclude", "someotherexclude"))))
+
+        ExcludeAutoConfigurationsEnvironmentPostProcessor().postProcessEnvironment(env, SpringApplication())
+        assertThat(env.getProperty("spring.autoconfigure.exclude"))
+            .contains(
+                "someotherexclude",
+                "org.springframework.boot.actuate.autoconfigure.observation.graphql.GraphQlObservationAutoConfiguration",
+                "org.springframework.boot.autoconfigure.graphql.security.GraphQlWebMvcSecurityAutoConfiguration",
+            )
+
+        assertThat(env.getProperty("spring.autoconfigure.exclude"))
+            .doesNotContain("someexclude")
+    }
 }