Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy tags from existing to next ASG #514

Closed
wants to merge 1 commit into from

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Mar 17, 2014

This PR causes existing tags assigned to an ASG to be copied when a new ASG is created. This is useful in cases where tags are assigned to resources outside of Asgard via, say, Cloudformation or the AWS CLI.

Tags with a key that starts with "aws" are dropped as that key prefix is reserved.

Fixing missing imports

filtering tags.

fixing npe.

code narc

test for tag copy
@cloudbees-pull-request-builder

asgard-pull-requests #343 SUCCESS
This pull request looks good

@joesondow
Copy link
Contributor

See #380 for a discussion of the outstanding issues with ASG tagging that we need to iron out.

@e0d e0d closed this Jan 31, 2016
@e0d e0d deleted the e0d/copy-tags-on-create-asg branch January 31, 2016 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants