Skip to content

Commit

Permalink
Linux client window management issue (#193)
Browse files Browse the repository at this point in the history
* Version bump (v4.0.1)

* Fixed issue that caused Linux client to quit when windows were closed.

* Removed unused IS_LINUX, linter
  • Loading branch information
rmcvey authored Jan 6, 2020
1 parent 222d03b commit d868847
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions scripts/maybeNotarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports.default = async function maybeNotarizing (context) {
const {
electronPlatformName,
appOutDir,
packager: { appInfo: { productFilename }}
packager: { appInfo: { productFilename } }
} = context

const missingCreds = !(APPLE_ID || APPLE_API_KEY)
Expand Down Expand Up @@ -49,6 +49,6 @@ exports.default = async function maybeNotarizing (context) {
params.ascProvider = ASC_PROVIDER
}

console.log("Notarizing app, coffee time?")
console.log('Notarizing app, coffee time?')
return notarize(params)
}
1 change: 1 addition & 0 deletions src/Action.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ class Action extends Component {
)
})
}

/**
* Provides variables to use in the instructions template. The returned keys
* can be used in conditionals in instructions.yml
Expand Down
6 changes: 2 additions & 4 deletions src/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import initProtocols from './lib/protocolHandlers'
import loadReactDevTools from './lib/loadReactDevTools'
import iconFinder from './lib/findIcon'
import startGraphQLServer from './server'
import { IS_LINUX, IS_MAC, IS_WIN } from './lib/platform'
import { IS_MAC, IS_WIN } from './lib/platform'
import AutoLauncher from './AutoLauncher'
import updateInit from './updater'

Expand Down Expand Up @@ -375,9 +375,7 @@ process.on('uncaughtException', err => {
})

app.on('window-all-closed', () => {
if (IS_LINUX) {
app.quit()
}
// minimize to tray
})

export {}

0 comments on commit d868847

Please sign in to comment.