Skip to content

Commit

Permalink
2.1.0 release (#78)
Browse files Browse the repository at this point in the history
Fixed:
- upstream auto update issue ([electron issue](electron-userland/electron-builder#3269))

Added:
- Thrift connection pooling
- Support for AWS workstations
- Scan duration to UI
- Automated testing for builds


* lock electron-builder/updater package versions to avoid bug

* Updated changelog and release notes
  • Loading branch information
rmcvey authored Oct 22, 2018
1 parent 1fd545a commit 8af1da0
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 31 deletions.
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,18 @@

All notable changes to this project will be documented in this file.

## [Unreleased](#)
## [2.1.0](https://github.com/Netflix-Skunkworks/stethoscope-app/tree/v2.1.0)

### Fixed
- upstream auto update issue ([electron issue](https://github.com/electron-userland/electron-builder/issues/3269))

### Added
- Thrift connection pooling
- Support for AWS workstations
- Scan duration to UI
- Automated testing for builds

----

## [2.0.6](https://github.com/Netflix-Skunkworks/stethoscope-app/tree/v2.0.6)

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"cors": "^2.8.4",
"cross-env": "^5.2.0",
"electron-settings": "^3.1.4",
"electron-updater": "^3.0.3",
"electron-updater": "3.0.3",
"es6-promisify": "^6.0.0",
"express": "^4.16.2",
"generic-pool": "^3.4.2",
Expand Down Expand Up @@ -150,7 +150,7 @@
"chai": "^4.1.2",
"chai-http": "^4.0.0",
"electron": "^2.0.6",
"electron-builder": "^20.28.4",
"electron-builder": "20.22.0",
"enzyme": "^3.3.0",
"enzyme-adapter-react-16": "^1.1.1",
"mocha": "^5.2.0",
Expand Down
25 changes: 6 additions & 19 deletions public/release-notes.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,8 @@
Changed:

- Stethoscope is now a tray/menubar only application!
- Normalized practice names to camelCase between `yaml` and `json`
- Closing window collapses app to menubar/tray instead of quitting
- Improved logging

Added:

- Automatic scanning (weekly scan by default) - controlled by `rescanIntervalSeconds` in [src/config.json](src/config.json)
- Basic support for internationalization (practices.{LANGUAGE_CODE}.yaml)
- Documentation around policies
- New Mac device versions
- Instructions now display dynamic content via handlebars preprocessing
- Production debugging capabilities
- Basic linux support (requires `root`)

Fixed:
- upstream auto update issue ([electron issue](https://github.com/electron-userland/electron-builder/issues/3269))

- Improved thrift connection stability and removed magic numbers/timing
- Windows not properly terminating osqueryd on close
Added:
- Thrift connection pooling
- Support for AWS workstations
- Scan duration to UI
- Automated testing for builds
16 changes: 7 additions & 9 deletions src/updater.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { dialog } = require('electron')
const { dialog, app } = require('electron')
const electronUpdater = require('electron-updater')

let updater
Expand Down Expand Up @@ -30,13 +30,6 @@ module.exports = function (env, mainWindow, log = console, OSQuery, server) {
attemptingUpdate = false
}
},
'before-quit-for-update': () => {
log.info('stopping osquery for app restart')
OSQuery.stop()
if (server && server.listening) {
server.close()
}
},
'update-available': () => {
dialog.showMessageBox({
type: 'info',
Expand Down Expand Up @@ -78,6 +71,11 @@ module.exports = function (env, mainWindow, log = console, OSQuery, server) {
message: 'Updates downloaded, Stethoscope will quit and relaunch.'
}, () => {
if (!isDev) {
OSQuery.stop()
if (server && server.listening) {
server.close()
}
// app.quit()
setImmediate(() => autoUpdater.quitAndInstall())
}
})
Expand All @@ -86,7 +84,7 @@ module.exports = function (env, mainWindow, log = console, OSQuery, server) {
'download-progress': (progressObj) => {
mainWindow.webContents.send('download:progress', progressObj)
// NOTE: uncomment to have download update progress displayed over app icon
mainWindow.setProgressBar(progressObj.percent / 100)
// mainWindow.setProgressBar(progressObj.percent / 100)
}
}

Expand Down

0 comments on commit 8af1da0

Please sign in to comment.