[FE][apispec-view] Screenshot tests restoration #2
+55
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
vOrigins
changed the title
JayLim2
reviewed
Mar 4, 2025
| @@ -18,6 +18,7 @@ | |||
| "@netcracker/qubership-apihub-api-diff": "1.0.4", | |||
| "@netcracker/qubership-apihub-api-doc-viewer": "2.0.3", | |||
| "@netcracker/qubership-apihub-http-spec": "5.5.7", | |||
| "@netcracker/qubership-apihub-jest-chrome-in-docker-environment": "dev", | |||
There was a problem hiding this comment.
don't we want to release new version of this package before merging ADV into develop?
There was a problem hiding this comment.
As discussed with @b41ex, we will leave the dev version for now.
There was a problem hiding this comment.
screenshot tests failed on these screenshots, right? because I don't see any difference on changed screenshot
There was a problem hiding this comment.
A few pixels difference due to Chrome version upgrade from 121 to 125.
CountRedClaw
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.