Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-106079] add containerd health check after restart #694

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

koryaga
Copy link
Contributor

@koryaga koryaga commented Sep 16, 2024

Description

  • containerd configuration procedure doesn't wait that containred daemon is healthy after restart. This may cause to issue when containerd daemon is not ready yet and cri request fails.

Fixes # (issue)
Possible way to reproduce:

# systemctl stop containerd; systemctl start containerd && systemctl status --no-pager containerd ; crictl info
...
FATA[0000] validate service connection: validate CRI v1 runtime API for endpoint "unix:///run/containerd/containerd.sock": rpc error: code = Unknown desc = server is not initialized yet

Solution

  • To add containerd health check in containerd configuration procedure using active polling with 10 sec timout

How to apply

Test Cases

TestCase 1

Steps:

Results:

Before After

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@koryaga koryaga added the bug Something isn't working label Sep 16, 2024
@koryaga koryaga requested review from n549 and Imadzuma September 16, 2024 16:12
@koryaga koryaga self-assigned this Sep 16, 2024
@koryaga koryaga marked this pull request as draft September 16, 2024 16:12
@koryaga koryaga requested a review from nikhil1697 September 16, 2024 16:12
@koryaga koryaga marked this pull request as ready for review September 17, 2024 06:50
@koryaga koryaga merged commit f0def2c into main Sep 19, 2024
43 checks passed
@koryaga koryaga deleted the containerd-restart-poll branch September 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants