-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPDEV-96114] add keepalived globals and custom template support #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Regression cases were tested/passed |
alexarefev
reviewed
Jan 10, 2024
ilia1243
approved these changes
Jan 11, 2024
ilia1243
reviewed
Jan 11, 2024
ilia1243
approved these changes
Jan 11, 2024
alexarefev
approved these changes
Jan 11, 2024
OleksandrIaresko
approved these changes
Jan 15, 2024
@shmo1218 pls update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now it's not possible to provide additional parameters for keepalived configuration except vrrp_ips.
But in fact, user should sometimes specify some custom parameters related to their environment, e.g.: https://serverfault.com/questions/821809/keepalived-send-gratuitous-arp-periodically/822004#822004
Fixes # (issue)
Solution
services.loadbalancer.keepalived.global
section forglobal_defs
keepalived parameters. Now following parameters are supported here:vrrp_garp_master_refresh
;config
orconfig_file
as for haproxy configuration;Test Cases
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
TestCase 1: custom
vrrp_garp_master_refresh
valueTest Configuration:
vrrp_garp_master_refresh
(e.g. 10) specified;Steps:
sudo tcpdump -i <interface> -nn arp
on some node;Results:
global_defs
section in/etc/keepalived/keepalived.conf
on balancersglobal_defs
section withvrrp_garp_master_refresh
specified in/etc/keepalived/keepalived.conf
on balancerstcpdump
handles garp requests only when vrrp ip changes the nodetcpdump
handles garp request for vrrp every 10 seconds (or other time, specified in vrrp_garp_master_refresh`)TestCase 2: custom
config
valueTest Configuration:
config
specified for keepalived;Steps:
Results:
/etc/keepalived/keepalived.conf
on balancers/etc/keepalived/keepalived.conf
on balancersTestCase 3: custom
config_file
valueTest Configuration:
config_file
specified for keepalived;Steps:
vrrp_garp_master_refresh_repeat
parameter inglobal_def
section with 5 value.sudo tcpdump -i <interface> -nn arp
on some node;Results:
vrrp_garp_master_refresh_repeat
in/etc/keepalived/keepalived.conf
on balancersvrrp_garp_master_refresh_repeat
in/etc/keepalived/keepalived.conf
on balancerstcpdump
handles garp requests only when vrrp ip changes the nodetcpdump
handles 5 garp requests for vrrp every 10 seconds (or other time, specified in vrrp_garp_master_refresh`)TestCase 4:
keep_config_updated=False
caseTest Configuration:
services.loadbalancer.keepalived.keep_config_updated=False
propertySteps:
Results:
Checklist
Unit tests
Indicate new or changed unit tests and what they do, if any.