Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Volume Audit log #3479

Merged
merged 4 commits into from
Feb 24, 2025
Merged

feat: Volume Audit log #3479

merged 4 commits into from
Feb 24, 2025

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 17, 2025
@rahulguptajss rahulguptajss linked an issue Feb 17, 2025 that may be closed by this pull request
[Audit Log] Know user that do a modification resize, create, delete a volume #3297
Closed
Hardikl
Hardikl previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
Few comments from UI side,

  • We can add few more vars, example volume var and that var should be only consumed in Volume related panels for filtering

@rahulguptajss
Copy link
Contributor Author

looks good. Few comments from UI side,

  • We can add few more vars, example volume var and that var should be only consumed in Volume related panels for filtering

A volume filter can be applied directly in the table. Since additional panels may be added to the dashboard later, a global volume filter doesn't seem necessary at this time.

@rahulguptajss rahulguptajss marked this pull request as draft February 20, 2025 12:52
@rahulguptajss rahulguptajss marked this pull request as ready for review February 21, 2025 09:30
@cgrinds cgrinds merged commit e0539ce into main Feb 24, 2025
10 checks passed
@cgrinds cgrinds deleted the rg2-audit-parsing branch February 24, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds left review comments

@Hardikl Hardikl Hardikl approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Audit Log] Know user that do a modification resize, create, delete a volume
3 participants
@rahulguptajss @cgrinds @Hardikl