Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASTRACTL-33890: astra-connector: unable to detect OCP flavor correctly. #361

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

vivintw
Copy link
Collaborator

@vivintw vivintw commented Jun 5, 2024

closes ASTRACTL-33890

  • updates astraconnect role with permissions to get, list clusteroperators.config.openshift.io

@vivintw vivintw requested a review from oscarr-ntap June 5, 2024 20:17
@vivintw vivintw self-assigned this Jun 5, 2024
@vivintw
Copy link
Collaborator Author

vivintw commented Jun 5, 2024

Testing

verify that the operator now creates the astraconnect cluster role with the required permissions

vivin@vivin-mac-1 ~ % kubectl get clusterRole astraconnect -o yaml | yq '.rules[] | select(.apiGroups[0] == "config.openshift.io")'
apiGroups:
  - config.openshift.io
resources:
  - clusteroperators
verbs:
  - get
  - list
vivin@vivin-mac-1 ~ %

Verify that the astra-connect pod now has permissions to do the flavor detection for OCP clusters correctly

time="2024-06-05T20:07:45Z" level=info msg="Detected Kubernetes server version" version="v1.28.8+8974577"
time="2024-06-05T20:07:45Z" level=info msg="Detected Kubernetes distro" K8sDistro=openshift

Verify that the flavor shows up correctly on the UI

Screenshot 2024-06-05 at 4 09 06 PM

closes ASTRACTL-33890
* updates astraconnect role with permissions to get, list clusteroperators.config.openshift.io
Copy link

github-actions bot commented Jun 6, 2024

Code Coverage

Package Line Rate
github.com/NetApp-Polaris/astra-connector-operator/app/conf 75%
github.com/NetApp-Polaris/astra-connector-operator/app/deployer/connector 91%
github.com/NetApp-Polaris/astra-connector-operator/app/deployer 100%
github.com/NetApp-Polaris/astra-connector-operator/app/deployer/model 100%
github.com/NetApp-Polaris/astra-connector-operator/app/deployer/neptune 85%
github.com/NetApp-Polaris/astra-connector-operator/app/register 16%
github.com/NetApp-Polaris/astra-connector-operator/details/k8s 62%
github.com/NetApp-Polaris/astra-connector-operator/details/k8s/precheck 56%
github.com/NetApp-Polaris/astra-connector-operator/details/operator-sdk/api/v1 46%
github.com/NetApp-Polaris/astra-connector-operator/details/operator-sdk/controllers 0%
github.com/NetApp-Polaris/astra-connector-operator/util 100%
Summary 55% (960 / 1752)

Minimum allowed line rate is 50%

@vivintw vivintw merged commit 248a8f4 into main Jun 6, 2024
3 checks passed
@vivintw vivintw deleted the ASTRACTL-33890 branch June 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants