trace(ProverJob): More info about job complexity #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The padded height is shown before a proving job starts, but it's only the padded height from the processor table (which often but not always dominates). With this PR, the actual proof complexity (dominating padded height) is printed once the job is done, as the proof (if well-formed) will contain this data.
Logging the proving speed would also make a lot of sense, dividing the (real) padded height with the time it took to produce the proof. That's not included in this PR, as I couldn't find a place in the code in the pipeline where both the time and the proof were in scope.