sender randomness type safety #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-da
force-pushed
the
danda/195_sender_randomness_type_safety
branch
from
8a906e9 to
758616d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #195.
This PR is a quick n dirty prototype to demonstrate feasability/direction with this. I am making it a draft PR as it is low priority and should definitely wait until after other pending PRs are reviewed and merged in, etc.
It implements a macro
digest_newtype!()that creates a new-type forDigestwith all the impls.The macro is used inside lib.rs like so:
note: these newtypes should probably be in their own module.
The rest of the changes are just adapting the code to use
SenderRandomnesseverywhere that previously expectedDigest.Future PRs could create newtypes for ReceiverPreImage, ReceiverPrivacyDigest, BlockDigest, and so on.