Correct muzzle flash when server switches weapons

[AdamTadeusz]

Description

Ideally the updateViewModelMuzzleFlash function should belong to the CNEOViewModelMuzzleFlash, but when doing it that way changing the muzzle flash skin doesn't seem to have an effect

Toolchain

• Windows MSVC VS2022
• Linux GCC Distro Native [Specify distro + GCC version]
• Linux GCC 10 Sniper 3.0

Linked Issues

• fixes Weapon view model muzzle flash not updated when calling Weapon_Switch on the server #571

[AdamTadeusz]

I should add that I avoided making these variables networked as I was worried they would generate traffic unnecessarily when a weapon is being fired. Having made them networked and observing generated traffic using dtwatchent entity id of muzzleflash I observed that these variables weren't being sent over the network, probably something clever decided its not necessary when the same function is ran both client and server side. However the scale of the muzzle flash would not update even though m_flModelScale is also a networked variable that exists both in a send and receive table.

This solution is the first one that I could find that fixed the whole problem in the fewest number of lines, if the reason why m_flModelScale was not being sent could be solved then making all these properties networked instead would be simpler.

Perhaps just updating the muzzle flash on this event would be even simpler, but then I ran into issues of the skin of the model (the 2 skin values switch between the circular and cross shape of the muzzle flash) not being updated correctly

[AdamTadeusz]

I think ill work on this some more and get one of the two nicer looking methods working

[AdamTadeusz]

ok I think we can make this slightly better