Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-round hints on HUD #866

Merged
merged 10 commits into from
Feb 2, 2025
Merged

Pre-round hints on HUD #866

merged 10 commits into from
Feb 2, 2025

Conversation

DESTROYGIRL
Copy link
Contributor

Description

Hints, hopefully identical to how they appeared in OGNT
Includes a convar to turn them on / off

Toolchain

  • Windows MSVC VS2022

Linked Issues

@DESTROYGIRL DESTROYGIRL added the VGUI Relates to the HUD or menu system in Source. Not technically accurate as not all HUD stuff is VGUI. label Jan 28, 2025
@DESTROYGIRL DESTROYGIRL requested a review from a team January 28, 2025 18:57
brysondev
brysondev reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this on my local env before approving. Can you send some screenshots to show me what it looks like on your end?

@DESTROYGIRL
Copy link
Contributor Author

I'd like to see this on my local env before approving. Can you send some screenshots to show me what it looks like on your end?

20250130145609_1

20250130145817_1

Vanishes at GOGOGO. Only visible once spawned

@AdamTadeusz
Copy link
Contributor

I think this is a toggle that could benefit from an entry on the multiplayer section of the settings page (we should probably add some subsections to that page but thats a different topic), you could see how to add a convar to that page by for example doing a search for all uses of the convar neo_aim_hold (ctrl-shift-f)

@AdamTadeusz
Copy link
Contributor

image
image
Neotokyo deals better with different aspect ratios and smaller window sizes

AdamTadeusz
AdamTadeusz reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@AdamTadeusz AdamTadeusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ypos isn't quite right on most resolutions but it looks ok. I'm worried what the hints will look like on very wide screens since the height of the hint depends on the width of the hint which depends on the width of the screen, but I have no way of testing that. Perhaps we should add some clamps to ensure the hint never goes off-screen?

@AdamTadeusz AdamTadeusz requested a review from a team February 1, 2025 14:24
brysondev
brysondev approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
lgtm

@brysondev brysondev merged commit 882cb71 into NeotokyoRebuild:master Feb 2, 2025
7 checks passed
@DESTROYGIRL DESTROYGIRL deleted the neohudhints branch February 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brysondev brysondev brysondev approved these changes

@AdamTadeusz AdamTadeusz AdamTadeusz approved these changes

Assignees
No one assigned
Labels
VGUI Relates to the HUD or menu system in Source. Not technically accurate as not all HUD stuff is VGUI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing hints during round freezetime
3 participants
@DESTROYGIRL @AdamTadeusz @brysondev