No ghost bunnyhopping + landing slowdown rework #857

AdamTadeusz · 2025-01-23T14:44:23Z

Description

This PR does two things.

Disables ghost bunnyhopping by default, following the same methodology as rains anti bunnyhopping plugin except using the current player max speed before slowdown from landing as a non-recon instead of using each classes max wallrun speed as the max.
Reworks the deceleration due to landing as a non-recon. After taking some videos in slow motion of an assault character running forward with a zr68s in their hands, jumping and then landing, I have observed that the character's max speed is set to 75 for 0.25 seconds, and then the acceleration is nerfed for a further 1/3 of a second, while the player slowly builds their speed back up to max speed. Given that after the initial 0.25 seconds after landing the player speed dips further below 75 before building back up to max speed, I believe the original game sets the max speed of the player to some value which increases linearly after landing, where a max speed low enough means that after 0.25 seconds this linearly increasing value does not yet pass 75 and so the speed dips for a moment.

This PR also includes the fixes to player speed when forced to duck from PR #846

Toolchain

Windows MSVC VS2022
Linux GCC Distro Native [Specify distro + GCC version]
Linux GCC 10 Sniper 3.0

Linked Issues

fixes Players can't bhop with the ghost #213

…tead keep track of whether player is carrying a weapon_ghost

brysondev · 2025-01-27T16:34:08Z

mp/src/game/server/neo/neo_player.cpp

-		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 0.75;
-		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 0.6;
-		speed /= m_iNeoClass == NEO_CLASS_RECON ? RECON_SPRINT_SPEED_MODIFIER : OTHER_CLASSES_SPRINT_SPEED_MODIFIER;
+		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 1.35;


Isn't this defined in a header somewhere?

I don't think so? Also I just did this pre-emptively in preperation for your pr to fix these values, if you're defining this in the header somewhere then ill update the pr once i see what that looks like

neo/mp/src/game/shared/neo/neo_player_shared.h

Line 42 in 0c4eb23

#define NEO_RECON_SPRINT_SPEED (NEO_BASE_SPRINT_SPEED * NEO_RECON_SPEED_MODIFIER)

technically this is the NEO_SPRINT_MODIFIER which has a value of 1.6, but recons have a different sprint modifier to the other classes

NEO_RECON_SPRINT_SPEED has a value of 272 if I'm not mistaken

(Edit) perhaps they have the same sprint speed modifier, I'm not going to pretend I know how to dive into the dll of the original game and get the exact values, but following the calculations here https://steamcommunity.com/sharedfiles/filedetails/?id=281690103 and ones ive taken myself I can say with confidence that assuming recons have a different sprint speed modifier is a decent enough way of getting the correct speed

Nagrywanie.ekranu.2025-01-29.174832.mp4

Here is a recording of the sprint speed of a recon in the original after removing all weapons (hence why the viewmodel is slightly off), the value of 272 is 2 units off and we're currently using the speed with a knife or other very light weapon as the base speed anyway (which despite Agiels protests I don't think is really an issue).

brysondev · 2025-01-27T16:34:21Z

mp/src/game/server/neo/neo_player.cpp

-		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 0.6;
-		speed /= m_iNeoClass == NEO_CLASS_RECON ? RECON_SPRINT_SPEED_MODIFIER : OTHER_CLASSES_SPRINT_SPEED_MODIFIER;
+		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 1.35;
+		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 1.6;


brysondev · 2025-01-27T16:34:41Z

mp/src/game/client/neo/c_neo_player.cpp

-		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 0.75;
-		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 0.6;
-		speed /= m_iNeoClass == NEO_CLASS_RECON ? RECON_SPRINT_SPEED_MODIFIER : OTHER_CLASSES_SPRINT_SPEED_MODIFIER;
+		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 1.35;


brysondev · 2025-01-27T16:34:47Z

mp/src/game/client/neo/c_neo_player.cpp

-		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 0.6;
-		speed /= m_iNeoClass == NEO_CLASS_RECON ? RECON_SPRINT_SPEED_MODIFIER : OTHER_CLASSES_SPRINT_SPEED_MODIFIER;
+		static constexpr float RECON_SPRINT_SPEED_MODIFIER = 1.35;
+		static constexpr float OTHER_CLASSES_SPRINT_SPEED_MODIFIER = 1.6;


Agiel · 2025-02-06T20:04:02Z

I had a look at the slowdown in OGNT again and it's slightly more convoluted than I remember.
Basically when you jump as a non-recon, your "slowdown factor" is set to 40.
This value decays by timeDelta * 35.
It is then applied to the max speed with the formula speed *= MAX(0.01, 1 - slowFactor / 20).
Finally, after applying all the other speed multipliers, it does

if speed < 55
  speed = 75

AdamTadeusz · 2025-02-07T13:46:13Z

I had a look at the slowdown in OGNT again and it's slightly more convoluted than I remember. Basically when you jump as a non-recon, your "slowdown factor" is set to 40. This value decays by timeDelta * 35. It is then applied to the max speed with the formula speed *= MAX(0.01, 1 - slowFactor / 20). Finally, after applying all the other speed multipliers, it does
if speed < 55
  speed = 75

So that supports what I've been observing with the player speed in slow motion. I drew a little graph to illustrate it with your code

I think this is one of those things where we could improve on the original, I don't think having this hitch where the player speed falls for a bit after player speed exceeds 55 only to start rising again is necessary or feels good

Agiel · 2025-02-07T13:56:31Z

I agree. One of 55 or 75 is probably a typo anyway. I guess making it 75 would be the least noticeable? Unless that would interfere with crouchwalk or something. What's the slowest speed you can reach currently by crouch/walking/aiming? I wouldn't mind making it 55 either, but that'd probably make bhopping harder.

Agiel · 2025-02-07T13:58:59Z

Alternatively, apply the jump slowdown first, and cap it at 75. Then do the walk/crouch/aim modifiers after and cap to whatever feels good.

AdamTadeusz · 2025-02-07T14:03:28Z

in the original you crouch walk with a pz at a speed of 60.75, and aiming in brings your speed back up to 75. I think back we thought the min speed was 56 so in rebuild aiming in lowers your speed to 56. Regardless of what the speed is after landing we bring it back up to at least 56 at the end

Agiel · 2025-02-07T14:11:38Z

Right, so we probably shouldn't cap it at 75 then. Best to do the jump slowdown first at 75, and then apply walk/crouch/aim and cap at 55.

AdamTadeusz · 2025-02-07T14:40:18Z

I assume we want the weapon slowdown done before the jump slowdown?

Also
const float timeSinceLanding = gpGlobals->curtime - m_flLastAirborneJumpOkTime;
constexpr float SLOWDOWN_TIME = 1.15f;
if (timeSinceLanding < SLOWDOWN_TIME)
{
speed = MAX(75,speed * MAX(0.01, 1 - (((SLOWDOWN_TIME - timeSinceLanding) * 35) * 0.05)));
}
This should be the equivalent without defining a slowdown variable

(Edit) no need for that division tbh

…hreshold

Agiel · 2025-02-07T15:17:37Z

mp/src/game/server/neo/neo_player.cpp

+		constexpr float SLOWDOWN_TIME = 1.15f;
+		if (timeSinceLanding < SLOWDOWN_TIME)
+		{
+			speed = MAX(75,speed * MAX(0.01, 1 - (((SLOWDOWN_TIME - timeSinceLanding) * 35) * 0.05)));


If you want to contract it further. 35 * 0.05 = 1.75.

maybe we don't need the inner max as well, it shouldn't make a noticeable difference right?

Probably not. And with the outer if-statement it shouldn't blow up in the wrong direction.
I realized something else though. In OGNT it's timeSinceJump but here it's timeSinceLanding. We'll want to subtract the air time from SLOWDOWN_TIME.

you're right, walking off of a ledge in the original does not cause a slowdown

Oh yeah, that's going to be annoying...

…s only applied when ducked and unducking, same as in the original

AdamTadeusz added 2 commits January 22, 2025 15:56

proof of concept

e2af38b

implement rains anti ghost bunnyhopping plugin natively.

1012061

AdamTadeusz requested a review from a team January 23, 2025 14:45

brysondev previously approved these changes Jan 25, 2025

View reviewed changes

update sprint speed modifiers

b8345de

AdamTadeusz dismissed brysondev’s stale review via b8345de January 27, 2025 14:57

weapon_ownsthisitem or some such too expensive to run every tick, ins…

1490ad1

…tead keep track of whether player is carrying a weapon_ghost

AdamTadeusz requested a review from brysondev January 27, 2025 15:29

brysondev previously approved these changes Jan 27, 2025

View reviewed changes

AdamTadeusz requested a review from a team February 6, 2025 17:18

calculation closer to original without the dip once speed passes 55 t…

0ae5d6a

…hreshold

AdamTadeusz dismissed brysondev’s stale review via 0ae5d6a February 7, 2025 14:51

Agiel reviewed Feb 7, 2025

View reviewed changes

AdamTadeusz added 5 commits February 7, 2025 15:19

little smaller

af2a74c

unnecessary max

8a8beda

landing slowdown actually jumping slowdown upon landing

52cfe4e

use flags instead to work out if ducking, means duck speed modifier i…

7950f36

…s only applied when ducked and unducking, same as in the original

wrong macro thank you linux

a01b304

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No ghost bunnyhopping + landing slowdown rework #857

No ghost bunnyhopping + landing slowdown rework #857

AdamTadeusz commented Jan 23, 2025 •

edited

Loading

brysondev Jan 27, 2025

AdamTadeusz Jan 27, 2025

brysondev Jan 29, 2025

AdamTadeusz Jan 29, 2025 •

edited

Loading

AdamTadeusz Jan 29, 2025

brysondev Jan 27, 2025

brysondev Jan 27, 2025

brysondev Jan 27, 2025

Agiel commented Feb 6, 2025 •

edited

Loading

AdamTadeusz commented Feb 7, 2025

Agiel commented Feb 7, 2025

Agiel commented Feb 7, 2025

AdamTadeusz commented Feb 7, 2025

Agiel commented Feb 7, 2025

AdamTadeusz commented Feb 7, 2025 •

edited

Loading

Agiel Feb 7, 2025

AdamTadeusz Feb 7, 2025

Agiel Feb 7, 2025

AdamTadeusz Feb 7, 2025

Agiel Feb 7, 2025

No ghost bunnyhopping + landing slowdown rework #857

Are you sure you want to change the base?

No ghost bunnyhopping + landing slowdown rework #857

Conversation

AdamTadeusz commented Jan 23, 2025 • edited Loading

Description

Toolchain

Linked Issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdamTadeusz Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Agiel commented Feb 6, 2025 • edited Loading

AdamTadeusz commented Feb 7, 2025

Agiel commented Feb 7, 2025

Agiel commented Feb 7, 2025

AdamTadeusz commented Feb 7, 2025

Agiel commented Feb 7, 2025

AdamTadeusz commented Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdamTadeusz commented Jan 23, 2025 •

edited

Loading

AdamTadeusz Jan 29, 2025 •

edited

Loading

Agiel commented Feb 6, 2025 •

edited

Loading

AdamTadeusz commented Feb 7, 2025 •

edited

Loading