Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement models for BrainForge service #8
base: dev
Are you sure you want to change the base?
Implement models for BrainForge service #8
Changes from all commits
637e418
e02a0b6
ef2fbac
a660766
d44fbcb
ad2d42c
48b7146
966534b
11f194c
ca32adc
9dd2ac2
449dcca
55bf516
bf36ffa
24a170c
8b83a41
82d8e1b
370e5f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns both all models and all personas, making
Persona
related requests uselessThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the
brainforge_get_personas
endpoint isn't necessary at all? The only use case I see for it now is if some client wants to get a specificmodel
@revision
without parsing all of the available modelsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it will never be the case
Because every service wants to request all available info at once and validate requests before been sent
But we can keep it, and deside later