Add: Image share option for dive plans #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolf-Smit
force-pushed
the
feature/add-share-image-option
branch
2 times, most recently
from
c709911 to
a0830cd
Compare
Right now this serves as an initial starting point, a sort of MVP implementation. It would be good to offer more information in shared images in the future; like graphs, additional general information (max depth, average depth) and more. Also the way in which compose is used to render images is experimental at best. Implements: #1
Rolf-Smit
force-pushed
the
feature/add-share-image-option
branch
from
a0830cd to
c8849ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this serves as an initial starting point, a sort of MVP implementation. It would be good to offer more information in shared images in the future; like graphs, additional general information (max depth, average depth) and more. Also the way in which compose is used to render images is experimental at best. On iOS there also is some lagg in the UI, would be good to offload the image transformation to the background.
Implements: #1