Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize files into module and feature-level folders #4826

Merged

Conversation

out-of-phaze
Copy link
Member

Description of changes

Commit names should be descriptive.
Makes scent stuff not use define strings because it's sort of overkill, nothing checks for them and they're just displayed.
Also cleans up some electric welder code?

Why and what will this PR improve

Bunch of reorganization and some comments laying out future groundwork for splitting up some of the more obnoxious types (/obj/structure/bed/chair/bench/pew being a good example)

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Jan 30, 2025
@MistakeNot4892
Copy link
Contributor

Scent includes out of order apparently.

@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. and removed ready for review This PR is ready for review and merge. labels Jan 30, 2025
@out-of-phaze out-of-phaze force-pushed the codequality/organize-folders branch from 28704bd to 39667d6 Compare January 30, 2025 15:09
@out-of-phaze out-of-phaze added ready for review This PR is ready for review and merge. and removed awaiting author This PR is awaiting action from the author before it can be merged. labels Jan 30, 2025
MistakeNot4892
MistakeNot4892 previously approved these changes Jan 31, 2025
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real talk I didn't read this diff

@MistakeNot4892 MistakeNot4892 added the has conflicts This PR needs updating and conflict resolution before it can be merged. label Jan 31, 2025
@out-of-phaze out-of-phaze force-pushed the codequality/organize-folders branch from 39667d6 to 51db1d7 Compare February 1, 2025 01:38
@out-of-phaze out-of-phaze force-pushed the codequality/organize-folders branch from 51db1d7 to 030c5b6 Compare February 1, 2025 01:49
@MistakeNot4892 MistakeNot4892 merged commit 0c5d0a0 into NebulaSS13:dev Feb 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts This PR needs updating and conflict resolution before it can be merged. ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants