-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize files into module and feature-level folders #4826
Merged
MistakeNot4892
merged 13 commits into
NebulaSS13:dev
from
out-of-phaze:codequality/organize-folders
Feb 1, 2025
Merged
Reorganize files into module and feature-level folders #4826
MistakeNot4892
merged 13 commits into
NebulaSS13:dev
from
out-of-phaze:codequality/organize-folders
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scent includes out of order apparently. |
MistakeNot4892
added
awaiting author
This PR is awaiting action from the author before it can be merged.
and removed
ready for review
This PR is ready for review and merge.
labels
Jan 30, 2025
out-of-phaze
force-pushed
the
codequality/organize-folders
branch
from
January 30, 2025 15:09
28704bd
to
39667d6
Compare
out-of-phaze
added
ready for review
This PR is ready for review and merge.
and removed
awaiting author
This PR is awaiting action from the author before it can be merged.
labels
Jan 30, 2025
MistakeNot4892
previously approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
real talk I didn't read this diff
MistakeNot4892
added
the
has conflicts
This PR needs updating and conflict resolution before it can be merged.
label
Jan 31, 2025
out-of-phaze
force-pushed
the
codequality/organize-folders
branch
from
February 1, 2025 01:38
39667d6
to
51db1d7
Compare
out-of-phaze
force-pushed
the
codequality/organize-folders
branch
from
February 1, 2025 01:49
51db1d7
to
030c5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has conflicts
This PR needs updating and conflict resolution before it can be merged.
ready for review
This PR is ready for review and merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Commit names should be descriptive.
Makes scent stuff not use define strings because it's sort of overkill, nothing checks for them and they're just displayed.
Also cleans up some electric welder code?
Why and what will this PR improve
Bunch of reorganization and some comments laying out future groundwork for splitting up some of the more obnoxious types (
/obj/structure/bed/chair/bench/pew
being a good example)