Collapsing screen obj references onto /datum/hud. #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
MistakeNot4892
force-pushed
the
rework/hud
branch
6 times, most recently
from
7107202 to
1d21267
Compare
MistakeNot4892
changed the title
MistakeNot4892
force-pushed
the
rework/hud
branch
8 times, most recently
from
f0b623d to
691670a
Compare
MistakeNot4892
added
ready for review
|
Borer stuff is pending some fixes to borers in general, everything else is good to review. |
|
Also needs a squash rebase I think. None of the changes work very well alone so not much point atomising it. |
MistakeNot4892
force-pushed
the
rework/hud
branch
3 times, most recently
from
14b3914 to
5601c8a
Compare
out-of-phaze
previously approved these changes
Jan 29, 2025
MistakeNot4892
force-pushed
the
rework/hud
branch
from
5601c8a to
bae905b
Compare
Snake casing hud procs, moving internals onto HUD datum. Fixing list clear in intent selector. Moving charge warning to HUD datum. Breaking up the status UI element and moving fire onto the HUD datum. Moving oxygen onto the HUD datum. Moving pressure, bodytemp and toxins onto the HUD datum. Moving robot module icon onto robot HUD datum. Moving zone selector onto the HUD datum and selected zone onto the mob. Moving hydration/nutrition onto HUD datum. Cleaning up move intent, moving creation to base HUD. Moving up hint onto HUD datum. Moving maneuver toggle onto HUD datum. Moving drop/resist onto HUD datum. Moving gun mode icons onto the HUD datum. Breaking up HUD icons to pass CI. Cleaning up some HUD lists and marking vars as private/protected. Declifying HUD elements. Fixes/tweaks to HUD rework PR. Redeclifying AI hud stuff. Declifying/cleaning up pAI HUD stuff. Cleaning up/fixing declified robot HUD. Tweaking AI HUD after rewrite. Tweaking borer HUD for rewrite PR. Readding animal HUD type. More borer HUD tweaks. Tweaking construct HUDs. Fixes FBP health. Tweaking borer hud.
MistakeNot4892
force-pushed
the
rework/hud
branch
from
bae905b to
20bb1ee
Compare
out-of-phaze
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
/decl/hud_elementtype as a way to dynamically populate and refer to HUD elements on/datum/hud.UI_ICON_FOOdefines to beHUD_FOOand use/decl/hud_elementinstead./obj/screenwherever possible./obj/screenreferences onto/datum/hudwherever possible./datum/hudand moves various stuff into procs instead of having it scattered through main code./datum/hudmember vars.Why and what will this PR improve
Much cleaner and easier to expand HUD code.
Fewer bespoke HUD overrides.
Easier to read HUD datum code.
Authorship
Myself.
Changelog
Nothing player-facing.
Issues
Testing