Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New year's eve fixes #2271

Merged
merged 15 commits into from
May 4, 2022
Merged

New year's eve fixes #2271

merged 15 commits into from
May 4, 2022

Conversation

quardbreak
Copy link
Contributor

@quardbreak quardbreak commented Dec 31, 2021 •
edited
Loading

Description of changes

Some fixes to things I found and able to resolve with my skills:

Why and what will this PR improve

It fixes some things

Authorship

Baystation12/Baystation12#31825
KekMan632 for advising with one part of fabricator ui, other stuff by me.

kelgaras
kelgaras suggested changes Dec 31, 2021
View reviewed changes
code/modules/mob/living/simple_animal/friendly/mouse.dm Show resolved Hide resolved
code/modules/client/ui_style.dm Outdated Show resolved Hide resolved
code/modules/client/ui_style.dm Outdated Show resolved Hide resolved
code/modules/client/ui_style.dm Outdated Show resolved Hide resolved
kelgaras
kelgaras previously approved these changes Dec 31, 2021
View reviewed changes
afterthought2
afterthought2 reviewed Dec 31, 2021
View reviewed changes
code/_helpers/icons.dm Outdated Show resolved Hide resolved
code/_helpers/icons.dm Outdated Show resolved Hide resolved
code/game/machinery/Sleeper.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/storage/storage.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/storage/storage.dm Outdated Show resolved Hide resolved
code/modules/client/client_procs.dm Show resolved Hide resolved
code/modules/mob/living/simple_animal/simple_animal.dm Outdated Show resolved Hide resolved
code/modules/nano/interaction/default.dm Show resolved Hide resolved
code/modules/overmap/sectors.dm Outdated Show resolved Hide resolved
code/modules/reagents/reagent_containers/glass.dm Outdated Show resolved Hide resolved
@quardbreak
Copy link
Contributor Author

quardbreak commented Dec 31, 2021 •
edited
Loading

More likely I will strip some fixes because I don't care to address feedback for them. I did what I did. If I have no idea how to make it proper and I don't care about it at all - it will be removed and only someone who cares about it more than me could do it better.

@quardbreak quardbreak force-pushed the bunchofjunk branch 4 times, most recently from 66913dc to 9ad5a6d Compare April 26, 2022 03:32
@afterthought2 afterthought2 added the ready for review This PR is ready for review and merge. label Apr 27, 2022
MistakeNot4892
MistakeNot4892 approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about the get_effective_view removals vs fixing get_effective_view but works for now.

@afterthought2 afterthought2 merged commit 99e94a1 into NebulaSS13:dev May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterthought2 afterthought2 afterthought2 left review comments

@MistakeNot4892 MistakeNot4892 MistakeNot4892 approved these changes

@kelgaras kelgaras kelgaras left review comments

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quardbreak @MistakeNot4892 @afterthought2 @kelgaras