Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to latest pyhelper #510

Merged
merged 1 commit into from
Mar 16, 2023
Merged

feat: move to latest pyhelper #510

merged 1 commit into from
Mar 16, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Mar 15, 2023

Issue

How

feat: move to latest pyhelper

  • move to latest pyhelper
  • make necessary changes to hardware.py to bring in the new changes
  • fix tests
  • delete unnecessary code and tests

Screenshots

References

Relates-to: NebraLtd/hm-pyhelper#230
Relates-to: NebraLtd/helium-syncrobit#2
Relates-to: NebraLtd/hm-pyhelper#222
Relates-to: NebraLtd/hm-pyhelper#221

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

- move to latest pyhelper
- make necessary changes to hardware.py to bring in the new changes
- fix tests
- delete unnecessary code and tests
@shawaj shawaj marked this pull request as ready for review March 15, 2023 22:57
@shawaj shawaj requested a review from a team as a code owner March 15, 2023 22:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj requested a review from a team March 15, 2023 23:50
@shawaj shawaj merged commit d481ef0 into master Mar 16, 2023
@shawaj shawaj deleted the shawaj/bump branch March 16, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants