Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seating Plan Seat Context changes #813

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

nick-knowles
Copy link
Contributor

Changes from Netex meeting
(a) Remove hasTray
(b) Add blankRowEndNoAisle to seat context
(c) Update example

nick-knowles and others added 7 commits December 11, 2024 16:58
Changes from Netex meeting
(a) Remove hasTray
(b) Add blankRowEndNoAisle to seat context
(c) Update example
Add further Seat contextenum values for facing window
reanme roeend enumeration
@ue71603 ue71603 added change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. needs documentation update The NeTEx document needs to be updated labels Dec 12, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Dec 12, 2024
@ue71603 ue71603 self-requested a review December 12, 2024 11:55
</xsd:annotation>
</xsd:enumeration>
<xsd:enumeration value="inMiddleWindowInFront"/>
<xsd:enumeration value="inMiddleAisleInFront"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "WindowInFront" and "AisleInFront" mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's just that the aisle (or window) is facing the seat. Even if not frequent in trains, that common in ferries and boats for example.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aurige, I see it is understandable in the ferry context. But then it would seem consequent to me to also have at least rowEndWindowInFront and rowEndAisleInFront - if not as well byWindowAisleInFront, byAisleWindowInFront, byAisleAisleInFront, etc. ... until the combinations become too strange. I share @JohanEntur's doubts whether this is the best approach. Might it be a discutable option to keep the SeatContext very basic and add a seating plan as an image in complex cases as ferries?

@JohanEntur
Copy link
Collaborator

I thought we were going for an array kind of list of context. Now its going to be endless combinations of concatenated possibilities, just like TransportSubmode.

@nick-knowles
Copy link
Contributor Author

UML Documentation update (1) Add Seating Plan Classifcation
image

(2) Update to existing Seating Plan Model UML
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. needs documentation update The NeTEx document needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants