Release ONT DDS project #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage ? 28.04%
=========================================
Files ? 37
Lines ? 5448
Branches ? 0
=========================================
Hits ? 1528
Misses ? 3920
Partials ? 0 ☔ View full report in Codecov by Sentry. |
alneberg
reviewed
Dec 10, 2024
taca/delivery/delivery_classes.py
Outdated
| try: | ||
| output = "" | ||
| for line in self._execute(cmd): | ||
| output += line |
There was a problem hiding this comment.
Does this generate a lot of output? I'm a bit worried it could accumulate or become a performance bottleneck
There was a problem hiding this comment.
It's so that we can see the progress bars that DDS prints. It's the same as we use today in taca-ngi-pipeline and it's been working OK so far I think.
aanil
reviewed
Dec 10, 2024
aanil
reviewed
Dec 10, 2024
Co-authored-by: Anandashankar Anil <[email protected]>
aanil
approved these changes
Dec 10, 2024
ssjunnebo
merged commit fa12734
into
NationalGenomicsInfrastructure:master
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a PID and DDS PID, release the project to the user.