-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure permissions of saved files adhere to umask setting #832
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 95 95
Lines 7182 7210 +28
=======================================
+ Hits 7156 7184 +28
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
I quickly trained some projects with the code in this PR, and noted that while
I wonder if there is something that can be done for this too...? Otherwise LGTM! |
It looks like |
Fixes #829
Many types of files saved by Annif using the
atomic_save()
operation had tighter permissions than expected. This is because they were first saved as temporary files, then renamed.This PR makes sure that the file permissions respect the umask setting. The unit test verifies that this works using different commonly used umask values.