Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Multivariate Drift Method: Classifier for Drift Detection #355

Merged
merged 14 commits into from
Feb 16, 2024
Merged

Conversation

nikml
Copy link
Contributor

@nikml nikml commented Jan 22, 2024

No description provided.

@nikml nikml requested a review from nnansters as a code owner January 22, 2024 10:18
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (808913c) 78.92% compared to head (9c2822f) 79.00%.

Files Patch % Lines
...riate/classifier_for_drift_detection/calculator.py 79.45% 22 Missing and 8 partials ⚠️
...tivariate/classifier_for_drift_detection/result.py 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   78.92%   79.00%   +0.07%     
==========================================
  Files         107      110       +3     
  Lines        8086     8268     +182     
  Branches     1290     1492     +202     
==========================================
+ Hits         6382     6532     +150     
- Misses       1364     1389      +25     
- Partials      340      347       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smith-kyle
Copy link

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/NannyML/nannyml/pull/355

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

@nnansters nnansters merged commit 3e11cd7 into main Feb 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants