Support BloomFilterMightContain expression #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
revans2
reviewed
Jul 24, 2023
sql-plugin/src/main/spark330/scala/com/nvidia/spark/rapids/GpuBloomFilter.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark330/scala/com/nvidia/spark/rapids/GpuBloomFilter.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark330/scala/com/nvidia/spark/rapids/GpuBloomFilter.scala
Show resolved
Hide resolved
sql-plugin/src/main/spark330/scala/com/nvidia/spark/rapids/GpuBloomFilter.scala
Outdated
Show resolved
Hide resolved
tests/src/test/spark330/scala/com/nvidia/spark/rapids/BloomFilterAggregateQuerySuite.scala
Show resolved
Hide resolved
revans2
reviewed
Jul 28, 2023
sql-plugin/src/main/spark330/scala/com/nvidia/spark/rapids/GpuBloomFilterMightContain.scala
Show resolved
Hide resolved
revans2
previously approved these changes
Jul 28, 2023
revans2
previously approved these changes
Jul 28, 2023
|
Updated to new BloomFilter interface in NVIDIA/spark-rapids-jni#1303. |
|
build |
revans2
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #7803. Depends on NVIDIA/spark-rapids-jni#1269.
This adds support for BloomFilterMightContain, which is the filter side needed for bloom-filter accelerated joins. The Bloom filter arrives as a scalar BINARY from a subquery, which is serialized as a big-endian buffer due to the use of DataInputStream. The GPU kernel operates on this big-endian format directly.