Build multiple go versions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
force-pushed
the
images
branch
from
255d1d5 to
2755b8c
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
images
branch
from
2755b8c to
d285dd7
Compare
elezar
reviewed
Jan 25, 2024
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| ARG GOLANG_VERSION=x.x.x | |||
| ARG GOLANG_VERSION=x.x | |||
elezar
reviewed
Jan 25, 2024
| @@ -31,9 +31,11 @@ on: | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go-version: ["1.21","1.20","1.19"] | |||
There was a problem hiding this comment.
I don't quite agree with this. For "reasons" we're still on 1.20.4 on some projects, so we may want to pin particular minor versions. We also refer to the full version in all consumers.
There was a problem hiding this comment.
this is an image for running CI tools, I don't see the advantage of a point release here.
I agree production images for a specific component could be tied to a specific version, but for CI steps, the generic 1.x.latest should be ok
There was a problem hiding this comment.
Let us make this change at a later stage if required. For now, let's match what we currently do -- which is to use a point release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.