[no-relnote] Add script to autogenerate Helm charts #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
commented
Feb 26, 2025
| VERSION=${VERSION#v} | ||
|
|
||
| # Create release assets to be uploaded | ||
| helm package deployments/helm/nvidia-dra-driver-gpu/ --version $VERSION --app-version $VERSION |
There was a problem hiding this comment.
I am not sure if going nvidia-dra-driver-gpu or k8s-dra-driver-gpu
There was a problem hiding this comment.
What do you mean? For the current source code the path you specified here is correct. Are you asking whether this should be changed?
There was a problem hiding this comment.
yeah the name, what do we prefer? this is me wondering about naming, not a blocker
elezar
reviewed
Feb 26, 2025
hack/package-helm-charts.sh
Outdated
| @@ -0,0 +1,28 @@ | |||
| #!/bin/bash -e | |||
There was a problem hiding this comment.
Should this be:
Suggested change
| #!/bin/bash -e | |
| #!/usr/bin/env bash |
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
helm_scripts
branch
from
1efb65b to
e7c0468
Compare
|
PTAL @elezar |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new file
hack/package-helm-charts.shwhich is a helper script to build the helm chart for thek8s-dra-driver-gpurepo