[FEATURE] [HELM] Add support to setup a custom serviceAccount #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marino Borges <[email protected]>
ArangoGutierrez
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Hey @marinoborges thanks for the PR! a nice addition for sure, happy to review
| @@ -52,9 +52,13 @@ spec: | |||
| {{- end }} | |||
| securityContext: | |||
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | |||
| {{- if $useServiceAccount }} | |||
There was a problem hiding this comment.
Not sure about this, it could introduce a breaking change , we need to find a way that won't break existing users scripts that may rely on this existing HELM setup
There was a problem hiding this comment.
It's not a breaking change because the existing logic is respected. It replaces this if with another one but still considering $useServiceAccount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174 with backward compatibility so this should be a minor change.