Improve readability and maintainability of Unitary Checker #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added detailed comments to enhance code clarity. - Improved variable naming for better understanding. - Ensured consistent formatting and indentation. - Optimized function structures for readability. Signed-off-by: Iqbal Bhatti <[email protected]>
boschmitt
suggested changes
Feb 6, 2025
Comment on lines
+55
to
+57
| if (!checkMod || !inputMod) { | ||
| llvm::errs() << "Error parsing input files.\n"; | ||
| return EXIT_FAILURE; |
There was a problem hiding this comment.
This is a good check to have.
Comment on lines
+84
to
+88
| if (!inputOp) { | ||
| llvm::errs() << "Function " << opName.str() << " not found in input.\n"; | ||
| exitStatus = EXIT_FAILURE; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Also good, since one might compile this without assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Readability and Maintainability of Unitary Checker
Description
This PR enhances the readability, maintainability, and overall structure of the Unitary Checker code while preserving its core functionality. The following improvements have been made:
These changes improve code maintainability, making it easier for developers to understand and contribute in the future.
Checklist
Looking forward to feedback and suggestions.