New cudaq::sample option: explicit measurements
#2567
Draft
+473
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
bmhowe23
changed the title
cudaq::sample option: stacked measurementscudaq::sample option: explicit measurements
bmhowe23
force-pushed
the
pr-stack-measurements
branch
from
5cfc41f to
e6d3bda
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Pradnya Khalate <[email protected]>
…uda-quantum into pr-stack-measurements
Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Run test on all available simulator targets Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
…onal logic * Simple Python test added * TODO: Add C++ test(s) Signed-off-by: Pradnya Khalate <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
This is purely a proof of concept because it relies on an environment variable to detect whether or not we're using Stim. It was verified with the following local tests: * BMH_IS_STIM=1 ctest -R "stim_" * BMH_IS_STIM=0 ctest -E "stim_" Signed-off-by: Ben Howe <[email protected]>
Total Test time (real) = 4179.65 sec
The following tests FAILED:
714 - SimpleQuditTester.checkSimple (Failed)
827 - anyon-tests (Failed) BMH killed because it was slow
829 - infleqtion-tests (Failed) BMH killed because it was slow
830 - ionq-tests (Failed) BMH killed because it was slow
831 - iqm-tests (Failed) BMH killed because it was slow
832 - oqc-tests (Failed) BMH killed because it was slow
833 - quantinuum-tests (Failed) BMH killed because it was slow
Errors while running CTest
Output from these tests are in: /workspaces/cuda-quantum/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
reviewed
Feb 9, 2025
Also, fix pre-existing tests and add a new one to exercise the newly added error message. Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now ... kicking the CI tires. This also needs spec review/approval before being merged.
This PR introduces a new
sample_optionsparameter calledexplicit_measurements. When this new option is selected, the behavior of the global register in thesample_resultis changed. Rather than retaining a single measurement of the final "state" of each qubit in the system, this new option instructs the runtime to record all qubit measurements into the global register ... effectively "stacking" all measurements together.While this change is supported by all simulators, the motivating factor for the change is that this will enable more efficient simulation when using Stim simulator for circuits containing mid-circuit measurements (as long as those mid-circuit measurements do not influence later gate sequences). Prior to this change, if one wanted to generically extract mid-circuit measurements out of the kernel, they would have to avoid using the
cudaq::sampleAPI.TODO