[features/run] Support for output record logging and parsing #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalatepradnya
force-pushed
the
record-log-parse
branch
from
cca6e13 to
9b50b10
Compare
khalatepradnya
force-pushed
the
record-log-parse
branch
2 times, most recently
from
2857a05 to
8505897
Compare
-- primitive types TODO: Handle arrays (vector of results) * Naive way of parsing integer array log Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
record-log-parse
branch
from
8505897 to
c7f2849
Compare
khalatepradnya
force-pushed
the
record-log-parse
branch
from
c7f2849 to
0171e26
Compare
Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
record-log-parse
branch
from
0171e26 to
cf3eb4f
Compare
khalatepradnya
commented
Feb 3, 2025
khalatepradnya
changed the title
khalatepradnya
changed the title
sacpis
reviewed
Feb 3, 2025
sacpis
reviewed
Feb 3, 2025
sacpis
reviewed
Feb 3, 2025
sacpis
reviewed
Feb 3, 2025
Comment on lines
+94
to
+103
| OutputType extractPrimitiveType(const std::string &label) { | ||
| if ('i' == label[0]) { | ||
| auto digits = std::stoi(label.substr(1)); | ||
| if (1 == digits) | ||
| return OutputType::BOOL; | ||
| return OutputType::INT; | ||
| } else if ('f' == label[0]) | ||
| return OutputType::DOUBLE; | ||
| throw std::runtime_error("Unknown datatype in label"); | ||
| } |
There was a problem hiding this comment.
We can store this in a map and get the output type if the label is found in the map.
sacpis
reviewed
Feb 3, 2025
| template <typename T> | ||
| void addPrimitiveRecord(T value) { | ||
| results.emplace_back( | ||
| OutputRecord{static_cast<void *>(new T(value)), sizeof(T)}); |
There was a problem hiding this comment.
instead of new, we can use unique pointer here.
There was a problem hiding this comment.
I tried using std::make_unique to create new value but I couldn't get the value out of it in my tests... :(
|
I think we can implement object-oriented parser here. We want to handle the different types of objects. Objects being Record, Header, Output. We can have RecordHandler as the parent class with some process method. And then implement that method in the inherited classes. In the RecordParser, we can have a map of object names and unique pointers of handlers. The parse method will then call the respective process method based on the object type. We need to give some thought here for nested structure. |
khalatepradnya
changed the title
…ented for testing only * Addressing PR comment Signed-off-by: Pradnya Khalate <[email protected]>
khalatepradnya
force-pushed
the
record-log-parse
branch
from
586bab8 to
22b2b7e
Compare
Signed-off-by: Pradnya Khalate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #2526