Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking vector size for a power of 2 #2491

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+38 −25
Draft

Checking vector size for a power of 2 #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0b02e2
Adding a check for the vector size and formatting
sacpis Dec 31, 2024
5281780
fixing the vector size
sacpis Dec 31, 2024
a1dda5a
moving the vector size check in get_state
sacpis Jan 3, 2025
9acafaa
Merge branch 'main' into check_vector_size_for_the_power_of_2
sacpis Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 20 additions & 25 deletions docs/sphinx/examples/python/visualization.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 18 additions & 0 deletions python/runtime/cudaq/algorithms/py_state.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,24 @@ state pyGetState(py::object kernel, py::args args) {

auto kernelName = kernel.attr("name").cast<std::string>();
auto kernelMod = kernel.attr("module").cast<MlirModule>();

// Validate vector size if it is used for state initialization
if (args.size() == 1) {
py::object arg = args[0];

// Check if the argument is an iterable
if (py::hasattr(arg, "__len__")) {
size_t size = py::len(arg);

if (size == 0 || (size & (size - 1)) != 0) {
throw std::invalid_argument(
fmt::format("Invalid vector size: {}. When initializing a qubit "
"register, the vector size must be a power of 2.",
size));
}
}
}

auto *argData = toOpaqueArgs(args, kernelMod, kernelName);

return details::extractState([&]() mutable {
Expand Down
Loading