Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure uccsd compiles for quantum devices #2458

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

Make sure uccsd compiles for quantum devices #2458

wants to merge 65 commits into from

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Dec 9, 2024 •
edited
Loading

Description

Make sure cudaq.uccsd compiles for quantum devices.

Details

  • uccsd: Update to not contain nested arrays
  • BaseRemoteRestQPU.h: run memtoreg before the first cc-loop-unroll pass (helps python's argument passing logic)
  • *.yml config files for quantum backends: use classical-optimization-pipeline to replace a bunch of existing passes
  • Add tests

Requires: NVIDIA/cudaqx#64
Requires: #2570
Requires: #2571
Requires: #2572
Requires: #2573
Requires: #2591
Requires: #2605

Closes:#2357

@annagrin
Temp
00aa8d8 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merged with main
1a300ba 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Add tests
b1b220c 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into fi…
0ca3674 
…x-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Revert temp changes
fac55bd 
Signed-off-by: Anna Gringauze <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@cuda-quantum-bot
Docs preview for PR #2458.
1ca1476
@annagrin
TEMP
ae35d16
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into fi…
ad486c1 
…x-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Fix bugs
4178f0e 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into fi…
cf283a3 
…x-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Add classic opts to LoopUnroll and add tests
3c07cad 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Remove local mounts
ff887ea 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
DCO Remediation Commit for Anna Gringauze <[email protected]>
718d9ed 
I, Anna Gringauze <[email protected]>, hereby add my Signed-off-by to this commit: ae35d16

Signed-off-by: Anna Gringauze <[email protected]>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
dcc2d34
schweitzpgi
schweitzpgi requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of making the patterns reside in files other than the pass where they are applied. That's not been the practice. So I think we should merge them back.

The exception to this general rule is when patterns are shared in multiple passes, which these are not AFAICT. Instead of block copying the same pattern in 2 or more different passes and where they will become hopelessly out of synch with one another, we want to put the pattern in an include file (foo.inc) and include that file in the n passes where it is needed. The patterns in LowerToCFG for IfOp is such a case, since it will be the same rewrite in LowerToCFG (indiscriminate) and in the canonicalization pattern you want to add (selected only when the condition is constant).

lib/Optimizer/Dialect/CC/CCOps.cpp Outdated Show resolved Hide resolved
lib/Optimizer/Dialect/CC/CCOps.cpp Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/CMakeLists.txt Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/CMakeLists.txt Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
22ce268
@annagrin annagrin marked this pull request as draft January 31, 2025 19:58
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
78c31c5
@annagrin annagrin mentioned this pull request Feb 2, 2025
Merged
@annagrin
temp
0a36b6b 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
temp
ec5468e 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into lo…
3dc023f 
…op-unroll-additional-opts

Signed-off-by: Anna Gringauze <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 9, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
e8fdcc0
@annagrin
Fix failed tests
a9ec857 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'lift-array-alloc-array-copy' of https://github.com/anna…
44c845b 
…grin/cuda-quantum into fix-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Add classical-optimization pass and pipeline
3ce961f 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Add more tests
0bdf458 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Remove unneded comments
0b58beb 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Remove unneded comments
f9cca25 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merged with classical-optimization-pipeline2
0cff560 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Use classical optimization pipeline in quantum config files
ba7b46d 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Revert lift-array-alloc changes
a62cbc7 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin annagrin changed the title Make sure uccsd from cudaqx compiles for quantum devices Make sure uccsd compiles for quantum devices Feb 11, 2025
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
bf41218
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
3d16126
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
b318748
@annagrin
Cleanup
e178987 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into fi…
a93ba6e 
…x-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
@cuda-quantum-bot
Docs preview for PR #2458.
fe87598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi schweitzpgi requested changes

@amccaskey amccaskey Awaiting requested review from amccaskey

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annagrin @schweitzpgi