Feat(Visual-Block): Introduce Visual-Block support with minor changes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement: Move _get_opening_char and _get_closing_char to _get_char
function, returning both opening and closing char.
Feat: Introduce Visual-Block mode support. Visual and Visual-Line modes
work as previous. Visual-Block mode will inject opening and closing char
for the entirety of the visual block per line. This is essentially a
automatic version of doing visual-block in front of a section and
after a section to inject opening and closing char as a macro.
Should not be there lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: Move _get_opening_char and _get_closing_char to _get_char function, returning both opening and closing char.
Feat: Introduce Visual-Block mode support. Visual and Visual-Line modes work as previous. Visual-Block mode will inject opening and closing char for the entirety of the visual block per line. This is essentially an automatic version of doing visual-block in front of a section and after a section to inject opening and closing char as a macro.
Future implementation can merge both approaches probably, but right now this is working.
Note: I added ignoring empty lines on Visual Block mode, which is different behavior to Visual and Visual Line modes.