Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use session #68

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Use session #68

merged 2 commits into from
Oct 9, 2024

Conversation

JunAishima
Copy link

No description provided.

@JunAishima JunAishima changed the base branch from master to deployed-on-amx-20180222 October 1, 2024 21:20
@JunAishima JunAishima changed the base branch from deployed-on-amx-20180222 to master October 1, 2024 21:23
@JunAishima JunAishima changed the base branch from master to v0.2.x October 3, 2024 17:42
@JunAishima
Copy link
Author

I dug around more and read through the docs and code, and found that there was no need to do anything more sophisticated than use the session.<methodname> call. The fix for the get method was to ensure that the params are passed in correctly (slightly different between session.get() and requests.get()).

  * enable persistent sessions to be used instead of an always-new
    session for each request
 * requests.api.put has data as a kwarg with default value None so
   this was why requests.get(url, data) worked
@JunAishima JunAishima merged commit b45f6f3 into NSLS2:v0.2.x Oct 9, 2024
10 checks passed
@JunAishima JunAishima deleted the use-session branch October 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants