-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Energy Standards Air Conditioner Data Update #1682
Open
leijerry888
wants to merge
37
commits into
master
Choose a base branch
from
data_update_99d14b7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14,017
−2,840
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
cc23547
data_update (unitary_air_conditioners_only) 99d14b7
leijerry888 a8c35aa
Merge branch 'master' into data_update_99d14b7
lymereJ 0288d3e
Move crac unit data to their own set of JSON files, add IEER to EER c…
lymereJ d0cfb67
Merge branch 'master' into data_update_99d14b7
lymereJ f97b622
Merge branch 'data_update_99d14b7' of https://github.com/NREL/openstu…
lymereJ 09da582
Merge branch 'master' into data_update_99d14b7
lymereJ 0c3a009
Rename method call.
lymereJ 66f3918
Remove rounding in naming.
lymereJ 298c5c5
Attempt to adress test failures.
lymereJ 7b1f69e
branch 'master' into data_update_99d14b7
lymereJ 4dbaf44
Merge branch 'master' into data_update_99d14b7
lymereJ 6243b0a
Merge branch 'master' into data_update_99d14b7
lymereJ 46f63af
Add placeholder for "2" ratings.
lymereJ 336663d
Merge branch 'data_update_99d14b7' of https://github.com/NREL/openstu…
lymereJ 4cd98c1
Merge branch 'master' into data_update_99d14b7
lymereJ 426d22d
Fix dates.
lymereJ 6979adc
Remove comments.
lymereJ e6c2ab8
Add missing reference.
lymereJ ce8667d
Merge branch 'master' into data_update_99d14b7
lymereJ de235f2
Clarification of changes and general clean-up. New unit tests.
lymereJ 9704e8a
Remove unused argument.
lymereJ fea6968
Add default value for argument.
lymereJ 6e8e232
Add additional search criteria.
lymereJ 5490087
Address NRCan test failures, temporarily deactivate a PRM test.
lymereJ a25a910
NRCan tests #2.
lymereJ d0f31bc
PRM test fix.
lymereJ 3532e35
Address PRM test failure #2.
lymereJ cc59b63
Missing fields.
lymereJ d8c1cfd
Fix multiplier issue identified by Kamel.
lymereJ ea9279e
Merge branch 'master' into data_update_99d14b7
lymereJ 889bf7b
Bump up maximum capacity of AC entries and update minimum EER require…
lymereJ e605746
Give priority to EER over IEER.
lymereJ 98a891c
Fix clause.
lymereJ 75d1f6b
Correct clause #2.
lymereJ 677d9c9
Fix clause #3.
lymereJ ba67d03
Merge branch 'master' into data_update_99d14b7
mdahlhausen 7273dbc
Merge branch 'master' into data_update_99d14b7
lymereJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New method to convert an IEER to a COP no fan. Note that this is just to estimate what would a reasonable full load gross COP would be for a specific IEER value. IEER-specific performance curves should then be applied. Copper could be used when it supports IEER rated equipment.