Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace logging #43

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Add trace logging #43

merged 5 commits into from
Jan 10, 2025

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jan 8, 2025

Add option for "TRACE" debugging level, which is more verbose than "DEBUG". Also added some trace calls that were useful in a recent (heavy) debug session in the async web scraping code.

@ppinchuk ppinchuk self-assigned this Jan 8, 2025
@ppinchuk ppinchuk requested a review from grantbuster January 8, 2025 01:42
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, is this something we would want to add to rex or is it a custom thing?

@ppinchuk
Copy link
Collaborator Author

It's a custom thing, but if we think it could be useful in rex, we could move it. It's mostly a development tool - much too verbose for any sort of production runs

@ppinchuk ppinchuk merged commit 6346376 into main Jan 10, 2025
15 checks passed
@ppinchuk ppinchuk deleted the pp/trace_logging branch January 10, 2025 18:56
github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants