-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEL can fail trace without triggering error #99
base: main
Are you sure you want to change the base?
Conversation
@SWRIganderson , got it! |
@@ -232,24 +238,32 @@ impl LocomotiveSimulation { | |||
self.loco_unit | |||
.set_cur_pwr_max_out(None, self.power_trace.dt(self.i))?; | |||
self.solve_energy_consumption( | |||
self.power_trace.pwr[self.i], | |||
if self.allow_trace_miss { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SWRIganderson , this did it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calbaker I'll check this out tonight.
@calbaker Thanks for getting this pulled off. The optional powertrace constraint works well. I was able to mess with it this weekend. It fails when it should, and does not fail when it shouldn't. I have a modified BEL example that I would like to include in ALTRIOS, but its probably needs to be cleaned up a bit. I will be committing it in the next couple of days once I get things dressed up for slides for the meeting on wednesday. The other thing that I think we should change is to make the allow_trace_miss argument an optional one with a default to false. I think this is a really useful argument that could easily shoot someone in the foot if they don't get it right. Let me know what you think about this. |
…o powertraces to demonstrate a potential pathway to identify optimal bel route deployment from event recorder data.
@SWRIganderson , I'd recommend putting your working BEL demo that shows trace miss working in |
… into fix/97-allow-bel-trace-miss
added PyYAML
solves #97