Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEL can fail trace without triggering error #99

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

calbaker
Copy link
Contributor

added PyYAML

solves #97

@calbaker
Copy link
Contributor Author

@SWRIganderson , got it!

@@ -232,24 +238,32 @@ impl LocomotiveSimulation {
self.loco_unit
.set_cur_pwr_max_out(None, self.power_trace.dt(self.i))?;
self.solve_energy_consumption(
self.power_trace.pwr[self.i],
if self.allow_trace_miss {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SWRIganderson , this did it!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calbaker I'll check this out tonight.

@SWRIganderson
Copy link
Collaborator

@calbaker Thanks for getting this pulled off. The optional powertrace constraint works well. I was able to mess with it this weekend. It fails when it should, and does not fail when it shouldn't.

I have a modified BEL example that I would like to include in ALTRIOS, but its probably needs to be cleaned up a bit. I will be committing it in the next couple of days once I get things dressed up for slides for the meeting on wednesday.

The other thing that I think we should change is to make the allow_trace_miss argument an optional one with a default to false. I think this is a really useful argument that could easily shoot someone in the foot if they don't get it right. Let me know what you think about this.

…o powertraces to demonstrate a potential pathway to identify optimal bel route deployment from event recorder data.
@calbaker
Copy link
Contributor Author

@SWRIganderson , allow_trace_miss is optional from the python side.

I'd recommend putting your working BEL demo that shows trace miss working in ./altrios/python/altrios/demos/bel_demo_w_trace_miss.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants