address my own review comments

NREL · Dec 13, 2023 · 8443025 · 8443025
1 parent d993358
commit 8443025
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/alfalfa_web/server/api-v2.js b/alfalfa_web/server/api-v2.js
@@ -377,7 +377,7 @@ router.post("/runs/:runId/points", async (req, res, next) => {
  */
 router.get("/runs/:runId/points/values", (req, res, next) => {
   api
-    .getPointsByRun(req.run)
+    .getPointsByType(req.run, ["OUTPUT", "BIDIRECTIONAL"])
     .then(async (points) => {
       const payload = {};
       await Promise.all(

diff --git a/alfalfa_web/server/api.js b/alfalfa_web/server/api.js
@@ -173,9 +173,9 @@ class AlfalfaAPI {
 
   removeRun = async (run) => {
     // Delete run
-    await this.run.deleteOne({ _id: run._id });
+    const { deletedCount } = await this.run.deleteOne({ _id: run._id });
 
-    if (run) {
+    if (deletedCount == 1) {
       // Delete points
       await this.points.deleteMany({ run: run._id });
 
@@ -188,7 +188,9 @@ class AlfalfaAPI {
       const key = await scan(this.redis, run.ref_id);
       if (key.length) await del(this.redis, key);
 
-      return true;
+      return Promise.resolve();
+    } else {
+      return Promise.reject("Could not remove Run");
     }
   };
 
@@ -346,7 +348,7 @@ class AlfalfaAPI {
     if (deletedCount == 1) {
       return Promise.resolve();
     } else {
-      return Promise.reject();
+      return Promise.reject("Could not remove Alias");
     }
   };