Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable send-to-Excel with equations for IPH models #1954

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Dec 6, 2024

Send-to-Excel with Equations requires modifcation of cashflow.lk and associated Excel workbooks that we will get to later as resources are available.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 6, 2024
@cpaulgilman cpaulgilman self-assigned this Dec 6, 2024
Copy link
Collaborator

@taylorbrown75 taylorbrown75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. All IPH models warn users Send to Excel with Equations is not available. Not sure why the tests are failing.

Copy link
Collaborator

@janinefreeman janinefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for all IPH configs! Thanks Paul!

@cpaulgilman cpaulgilman merged commit 3ea463d into develop Dec 10, 2024
8 checks passed
@cpaulgilman cpaulgilman deleted the iph-send-to-excel branch December 10, 2024 00:47
@cpaulgilman cpaulgilman added dev bug Internal bug that should not be included in release notes added to release notes PR and/or issue has been added to release notes for a public release and removed dev bug Internal bug that should not be included in release notes labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants