Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help for release candidate 2023 #1585

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Help for release candidate 2023 #1585

merged 4 commits into from
Nov 17, 2023

Conversation

cpaulgilman
Copy link
Collaborator

Also fixes some broken help links

@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Nov 17, 2023
@cpaulgilman cpaulgilman requested a review from sjanzou November 17, 2023 00:15
@cpaulgilman cpaulgilman self-assigned this Nov 17, 2023
@janinefreeman janinefreeman requested review from janinefreeman and removed request for sjanzou November 17, 2023 16:44
@janinefreeman
Copy link
Collaborator

@cpaulgilman I'll take over this PR review if a Windows only review is ok? If so, anything in particular you want me to test, or just check out the updated test files?

@cpaulgilman
Copy link
Collaborator Author

@cpaulgilman I'll take over this PR review if a Windows only review is ok? If so, anything in particular you want me to test, or just check out the updated test files?

Thanks. Testing in Windows should be sufficient. Clicking through UI pages and pressing F1 to make sure Help opens to the correct topic would be great, especially for new Hybrid configurations.

Copy link
Collaborator

@janinefreeman janinefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bunch of spot-checking in the hybrid cmods, for both the technology and financial models, and tried navigating around the help system at random. All looks good here.

@cpaulgilman cpaulgilman merged commit 7503ac4 into develop Nov 17, 2023
4 checks passed
@sjanzou sjanzou deleted the startup-help-id-fixes branch November 19, 2023 08:23
@cpaulgilman cpaulgilman added dev bug Internal bug that should not be included in release notes and removed dev bug Internal bug that should not be included in release notes labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants