Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing issues on mac build when running defaults #1479 #1502

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Oct 17, 2023

GitHub Actions failing for Mac builds for some time per #1479

@sjanzou sjanzou self-assigned this Oct 17, 2023
@sjanzou sjanzou requested a review from cpaulgilman October 17, 2023 20:01
@sjanzou sjanzou linked an issue Oct 18, 2023 that may be closed by this pull request
@sjanzou sjanzou requested a review from brtietz October 18, 2023 05:04
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and looks good to GitHub Actions too!

@brtietz brtietz merged commit 07b2508 into develop Oct 18, 2023
4 checks passed
@cpaulgilman
Copy link
Collaborator

Built successfully on Mac Pro Mid 2012 Intel Core i5 running MacOS 10.15.7

@sjanzou
Copy link
Collaborator Author

sjanzou commented Oct 19, 2023

Built successfully on Mac Pro Mid 2012 Intel Core i5 running MacOS 10.15.7

Great! Thanks @cpaulgilman

@sjanzou sjanzou deleted the SAM_1479 branch October 19, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac build github actions failing
3 participants