Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSP entries for PySAM config_to_cmod_name table #1490

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Update CSP entries for PySAM config_to_cmod_name table #1490

merged 3 commits into from
Oct 24, 2023

Conversation

dguittet
Copy link
Collaborator

@dguittet dguittet commented Oct 6, 2023 •
edited
Loading

Pull Request Template

Description

Update the table that matches the SAM configuration with the compute modules for CSP technologies.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

@dguittet
Copy link
Collaborator Author

Have discussed this with @tyneises who said it looks good, so just going to merge

@dguittet dguittet merged commit 723174c into develop Oct 24, 2023
4 checks passed
@dguittet dguittet deleted the pysam_csp branch October 24, 2023 20:48
@brtietz brtietz added this to the SAM Fall 2023 Release milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyneises tyneises Awaiting requested review from tyneises

@qualand qualand Awaiting requested review from qualand

@taylorbrown75 taylorbrown75 Awaiting requested review from taylorbrown75

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SAM Fall 2023 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dguittet @brtietz