Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callbacks for wind bos system cost options for hybrids #1489

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

mjprilliman
Copy link
Collaborator

Pull Request Template

Description

-Hides button for Wind balance of system costs for hybrid systems
-Organizes wind hybrid callbacks into single function

Fixes #1470

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added bug dev bug Internal bug that should not be included in release notes labels Oct 5, 2023
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Oct 5, 2023
@mjprilliman mjprilliman self-assigned this Oct 5, 2023
@cpaulgilman
Copy link
Collaborator

I suggest also hiding the wind resource file reference_resource_file if it is not used for the turbine cost estimate -- I expected the turbine cost estimate to change with the weather file, but it doesn't. I think the wind resource file is only relevant for the BOS model.

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mjprilliman
Copy link
Collaborator Author

@sjanzou @cpaulgilman Do we know why the mac tests are failing on PR's?

@mjprilliman mjprilliman merged commit d401762 into develop Oct 6, 2023
@mjprilliman mjprilliman deleted the wind-hybrid-bos-cost branch October 6, 2023 18:08
@sjanzou
Copy link
Collaborator

sjanzou commented Oct 7, 2023

@sjanzou @cpaulgilman Do we know why the mac tests are failing on PR's?

@mjprilliman , tests pass locally - see issue #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wind Hybrids is Missing "Balance of System" Inputs
3 participants